2040480420
Merge pull request #1474 from miminar/respect-errors
...
Respect errors returned from middleware code
2016-02-26 23:28:37 -08:00
bb4d128523
Merge pull request #1482 from stweil/master
...
Fix some typos in comments and strings
2016-02-23 14:08:21 -08:00
d16f3046c6
Fix some typos in comments and strings
...
All of them were found and fixed by codespell.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
2016-02-23 22:33:38 +01:00
e3a9a99097
Merge pull request #1471 from RichardScothern/tag-headers
...
Enable proxying registries to downgrade fetched manifests to Schema 1.
2016-02-23 11:08:46 -08:00
29e0411f00
Enable proxying registries to downgrade fetched manifests to Schema 1.
...
Ensure Accept headers are sent with TagService.Get (which hits manifest
endpoints). Add support for remote Get and Put for the proxied blobstore.
Signed-off-by: Richard Scothern <richard.scothern@gmail.com>
2016-02-22 17:56:48 -08:00
776e01f8bc
Defined ErrAccessDenied error
...
Middleware code may perform additional checks on blobs written. Allow it
to return access denied errors that will result in 403 Forbidden.
Signed-off-by: Michal Minar <miminar@redhat.com>
2016-02-22 21:12:59 +01:00
1f0fa8fa4e
Merge pull request #1477 from xiekeyang/unit-test
...
compare error output in tagstore unit test
2016-02-22 10:13:16 -08:00
c58aa8a50a
compare error output in tagstore unit test
...
Signed-off-by: xiekeyang <xiekeyang@huawei.com>
2016-02-22 17:34:22 +08:00
db7411ff2e
Merge pull request #1466 from RichardScothern/proxy-lazy-auth
...
Lazily evaluate auth challenges
2016-02-19 15:06:35 -08:00
18fd1c0702
Extend authChallenger interface to remove type cast.
...
Signed-off-by: Richard Scothern <richard.scothern@gmail.com>
2016-02-17 13:07:14 -08:00
464d03cdd6
Merge pull request #1469 from noxiouz/fix_storage_interface_desc
...
Fix description of StorageDriver.WriteStream
2016-02-17 10:46:11 -08:00
d8f472c200
Merge pull request #1468 from HuKeping/master
...
Cleanup: remove unused log
2016-02-17 10:00:02 -08:00
2e8244822c
Fix description of StorageDriver.WriteStream
...
Offset can be more than CurrentSize as long as this case is checked
by DriverSuite.testContinueStreamAppend.
Signed-off-by: Anton Tiurin <noxiouz@yandex.ru>
2016-02-17 13:57:20 +03:00
20bc910cdf
Cleanup: remove unused log
...
Signed-off-by: Hu Keping <hukeping@huawei.com>
2016-02-17 14:11:20 +08:00
9a819f80e2
Merge pull request #1467 from BrianBland/s3awsFixTest
...
[driver/s3aws] Fix TestStorageClass
2016-02-16 18:14:34 -08:00
c6871737bc
[driver/s3aws] Fix TestStorageClass
...
Fixes bug in TestStorageClass for s3aws driver where the "standard" file
was checked for reduced-redundnancy storage.
Signed-off-by: Brian Bland <brian.bland@docker.com>
2016-02-16 17:50:55 -08:00
7d16fee7a4
To avoid any network use unless necessary, delay establishing authorization
...
challenges with the upstream until any proxied data is found not to be local.
Implement auth challenges behind an interface and add to unit tests. Also,
remove a non-sensical unit test.
Signed-off-by: Richard Scothern <richard.scothern@docker.com>
2016-02-16 11:53:42 -08:00
881ef1096f
Merge pull request #1385 from BrianBland/s3UseAWSLibrary
...
[driver/s3] Use aws/aws-sdk-go instead of goamz for s3 driver and cloudfront
2016-02-16 11:19:15 -08:00
9f101fb6ef
Merge pull request #1462 from liuchang23/master
...
enhance log message of oss driver
2016-02-16 10:49:18 -08:00
7ca24a7f5a
fix gofmt
...
Signed-off-by: liuchang0812 <liuchang0812@gmail.com>
2016-02-16 11:42:09 +08:00
ad6a0735d2
closes #1461 , enhance log message of oss driver
...
Signed-off-by: liuchang0812 <liuchang0812@gmail.com>
2016-02-16 11:17:09 +08:00
d5a38e4c5f
Adds new s3 driver using aws-sdk-go instead of goamz
...
Keeps old s3 driver, renames to s3goamz, registers new s3 driver as both
"s3" and "s3aws"
Changes cloudfront middleware to use aws-sdk-go
Signed-off-by: Brian Bland <brian.bland@docker.com>
2016-02-12 15:59:26 -08:00
7e0e141948
Merge pull request #1452 from aaronlehmann/export-no-credentials-error
...
Export "no basic auth credentials" as an error value
2016-02-11 10:09:22 -08:00
ff9448cc4b
Merge pull request #1451 from aaronlehmann/typo-fixes
...
Typo fixes in comments
2016-02-10 17:12:00 -08:00
cffb4bbbfd
Export "no basic auth credentials" as an error value
...
Making this an exported error value will allow users of the
registry/client/auth module to have consistent behavior between
authentication failures and cases where no credentials are provided.
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
2016-02-10 16:46:57 -08:00
55906ee341
Merge pull request #1445 from dmcgowan/fix-manifest-digest-header
...
Fix schema1 manifest etag and docker content digest header
2016-02-10 16:27:18 -08:00
f77c82ebb3
Typo fixes in comments
...
Correct spelling of words in source code comments.
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
2016-02-10 16:26:29 -08:00
2177a6a1bf
Merge pull request #1420 from dmcgowan/configurable-trust-key
...
Add option to disable signatures
2016-02-10 16:15:59 -08:00
956ece5c70
Add option to disable signatures
...
Add option for specifying trust key for signing schema1 manifests.
Since schema1 signature key identifiers are not verified anywhere and deprecated, storing signatures is no longer a requirement.
Furthermore in schema2 there is no signature, requiring the registry to already add signatures to generated schema1 manifests.
Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
2016-02-10 15:20:39 -08:00
ae59517936
Fix schema1 manifest etag and docker content digest header
...
When schema2 manifests are rewritten as schema1 currently the etag and docker content digest header keep the value for the schema2 manifest.
Fixes #1444
Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
2016-02-09 18:28:43 -08:00
3cf01ffa1f
Merge pull request #1414 from BrianBland/s3ImproveConfigParsing
...
Improves flexibility of configuration handling for S3 driver
2016-02-09 18:10:03 -08:00
4bb5f80885
Improves flexibility of configuration handling for S3 driver
...
Treats nil parameters the same as unprovided parameters (fixes issues
where certain parameters are printed to "<nil>").
Accepts "true" and "false" string values for boolean parameters.
Signed-off-by: Brian Bland <brian.bland@docker.com>
2016-02-09 17:27:16 -08:00
8745d31f60
Merge pull request #1419 from aaronlehmann/safer-header-copying
...
On redirect, only copy headers when they don't already exist in the redirected request
2016-02-05 12:14:01 -08:00
d928dc0b92
Merge pull request #1425 from RichardScothern/fix-build
...
Correct type for repo reference
2016-02-04 17:47:03 -08:00
9894643c88
Correct type for repo reference
...
Signed-off-by: Richard Scothern <richard.scothern@gmail.com>
2016-02-04 17:32:55 -08:00
0751bb3179
Merge pull request #1417 from RichardScothern/token-print
...
Print the correct token expiration time
2016-02-04 16:57:08 -08:00
fe0e76f322
Merge pull request #1350 from aibaars/storage-filewriter-pointer
...
Storage: remove bufferedFileWriter (dead code)
2016-02-04 16:47:52 -08:00
def3e430bb
Merge pull request #1401 from BrianBland/s3StorageClass
...
Adds "storageclass" configuration parameter for S3 driver.
2016-02-04 16:44:13 -08:00
ab6c08691e
Merge pull request #1408 from aaronlehmann/repository-interface
...
Rename Name method of Repository to Named
2016-02-04 16:43:35 -08:00
6158eb544d
Rename Name method of Repository to Named
...
This makes code that gets the name as a string read like
repo.Named().Name() instead of repo.Name().Name().
Requested in
https://github.com/docker/docker/pull/19887#discussion_r51479753
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
2016-02-04 09:55:36 -08:00
95b9c7281b
read the actual number of bytes according to the initial size.
...
Signed-off-by: yuzou <zouyu7@huawei.com>
2016-02-04 16:14:35 +08:00
bbf983c061
On redirect, only copy headers when they don't already exist in the redirected request
...
A changeset under consideration for Go 1.7 would automatically copy
headers on redirect. This change future-proofs our code so we won't make
duplicate copies of the headers if net/http does it automatically in the
future.
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
2016-02-03 13:19:44 -08:00
091c12f86b
Print the correct token expiration time
...
Signed-off-by: Richard Scothern <richard.scothern@gmail.com>
2016-02-03 10:42:32 -08:00
c4b79bda8a
Merge pull request #1410 from aaronlehmann/failured
...
Correct ErrAuthenticationFailure message
2016-02-01 19:20:35 -08:00
95a50c7236
Correct ErrAuthenticationFailure message
...
This was "authentication failured". Change it to "authentication
failure".
Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
2016-02-01 17:03:41 -08:00
9b395d0789
Merge pull request #1403 from dmcgowan/auth-const-keys
...
Update auth context keys to use constant
2016-02-01 16:29:07 -08:00
db48ad4d0f
Merge pull request #1390 from dmcgowan/token-server
...
Simple integration test token server
2016-02-01 16:27:49 -08:00
a2ade36ecf
Adds test for S3 storage class configuration option
...
Signed-off-by: Brian Bland <brian.bland@docker.com>
2016-02-01 16:01:55 -08:00
8e7910826e
Adds "storageclass" configuration parameter for S3 driver.
...
Defaults to STANDARD, also supports REDUCED_REDUNDANCY.
Signed-off-by: Brian Bland <brian.bland@docker.com>
2016-02-01 16:01:19 -08:00
6417c05a27
Merge pull request #1381 from BrianBland/s3CustomUAString
...
Adds custom registry User-Agent header to s3 HTTP requests
2016-02-01 15:40:36 -08:00
Aaron Lehmann
Brian Bland
Stefan Weil
Richard Scothern
Michal Minar
Richard Scothern
xiekeyang
Anton Tiurin
HuKeping
Brian Bland
liuchang0812
Olivier Gambier
Derek McGowan
yuzou