ENH: Feedback

- Added encounter movement to token data
- Use signs for ability roll types
- Fixed roll mode on item roll

src/lang/en.json

@@ -32,9 +32,6 @@
   "OSE.roll.exploration": "{exploration} test",
   "OSE.roll.details.exploration": "Roll 1d6 <= {expl} for success",
   "OSE.roll.reaction": "Reaction roll",
-  "OSE.roll.type.result": "Result",
-  "OSE.roll.type.above": "Above",
-  "OSE.roll.type.below": "Below",
 
   "OSE.table.treasure.roll": "Roll Treasure",
 

src/lang/es.json

@@ -32,9 +32,6 @@
   "OSE.roll.exploration": "Prueba de {exploration}",
   "OSE.roll.details.exploration": "Tirar 1d6 <= {expl} para éxito",
   "OSE.roll.reaction": "Tirada de Reacción",
-  "OSE.roll.type.result": "Resultado",
-  "OSE.roll.type.above": "Encima",
-  "OSE.roll.type.below": "Debajo",
 
   "OSE.table.treasure.roll": "Roll Treasure",
   

src/lang/fr.json

@@ -32,9 +32,6 @@
   "OSE.roll.exploration": "Test de {exploration}",
   "OSE.roll.details.exploration": "Lancez 1d6 <= {expl} pour réussir",
   "OSE.roll.reaction": "Jet de Réaction",
-  "OSE.roll.type.result": "Resultat",
-  "OSE.roll.type.above": "Au-Dessus",
-  "OSE.roll.type.below": "En-Dessous",
 
   "OSE.table.treasure.roll": "Trésor Aléatoire",
 

src/module/actor/entity.js

@@ -22,6 +22,7 @@ export class OseActor extends Actor {
     } else {
       data.initiative.value = 0;
     }
+    data.movement.encounter = data.movement.base / 3;
   }
   /* -------------------------------------------- */
   /*  Socket Listeners and Handlers
@@ -454,6 +455,7 @@ export class OseActor extends Actor {
     const data = this.data.data;
 
     const standard = {
+      0: -3,
       3: -3,
       4: -2,
       6: -1,
@@ -488,6 +490,7 @@ export class OseActor extends Actor {
     );
 
     const capped = {
+      0: -2,
       3: -2,
       4: -1,
       6: -1,
@@ -508,6 +511,7 @@ export class OseActor extends Actor {
     data.scores.cha.loyalty = data.scores.cha.mod + 7;
 
     const od = {
+      0: 0,
       3: 1,
       9: 2,
       13: 3,
@@ -520,6 +524,7 @@ export class OseActor extends Actor {
     );
 
     const literacy = {
+      0: "",
       3: "OSE.Illiterate",
       6: "OSE.LiteracyBasic",
       9: "OSE.Literate",
@@ -530,6 +535,7 @@ export class OseActor extends Actor {
     );
 
     const spoken = {
+      0: 0,
       3: 0,
       13: 2,
       16: 3,

src/module/actor/monster-sheet.js

@@ -41,7 +41,6 @@ export class OseActorSheetMonster extends OseActorSheet {
 
     // Settings
     data.config.morale = game.settings.get("ose", "morale");
-    console.log(data);
     data.data.details.treasure.link = TextEditor.enrichHTML(data.data.details.treasure.table);
     return data;
   }

src/module/config.js

@@ -8,14 +8,9 @@ export const OSE = {
     cha: "OSE.scores.cha.long",
   },
   roll_type: {
-    result: "OSE.roll.type.result",
-    above: "OSE.roll.type.above",
-    below: "OSE.roll.type.below"
-  },
-  roll_type_sign: {
-    result: "",
-    above: ">=",
-    below: "<="
+    result: "=",
+    above: "≥",
+    below: "≤"
   },
   saves_short: {
     death: "OSE.saves.death.short",

src/module/item/entity.js

@@ -168,7 +168,7 @@ export class OseItem extends Item {
       case "ability":
         let roll = "";
         roll += data.roll ? data.roll : "";
-        roll += data.rollType ? CONFIG.OSE.roll_type_sign[data.rollType] : "";
+        roll += data.rollType ? CONFIG.OSE.roll_type[data.rollType] : "";
         roll += data.rollTarget ? data.rollTarget : "";
         return `${formatTag(data.requirements)}${formatTag(roll)}`;
     }

src/ose.js

@@ -63,7 +63,7 @@ Hooks.once("init", async function () {
  */
 Hooks.once("setup", function () {
   // Localize CONFIG objects once up-front
-  const toLocalize = ["saves_short", "saves_long", "scores", "armor", "colors", "roll_type", "tags"];
+  const toLocalize = ["saves_short", "saves_long", "scores", "armor", "colors", "tags"];
   for (let o of toLocalize) {
     CONFIG.OSE[o] = Object.entries(CONFIG.OSE[o]).reduce((obj, e) => {
       obj[e[0]] = game.i18n.localize(e[1]);

src/template.json

@@ -15,12 +15,10 @@
           "max": 20
         },
         "ac": {
-          "value": 0,
-          "mod": 0
+          "value": 0
         },
         "aac": {
-          "value": 0,
-          "mod": 0
+          "value": 0
         },
         "thac0": {
           "value": 19,
@@ -48,8 +46,7 @@
           }
         },
         "movement": {
-          "base": 120,
-          "value": ""
+          "base": 120
         },
         "initiative": {
           "value": 0,
@@ -93,7 +90,7 @@
         "alignment": "",
         "level": 1,
         "xp": {
-          "next": 0,
+          "next": 2000,
           "value": 0,
           "bonus": 0
         }

src/templates/items/ability-sheet.html

@@ -22,7 +22,7 @@
             <input type="text" name="data.roll" value="{{data.roll}}" data-dtype="String" />
           </div>
         </div>
-        <div class="form-group block-input">
+        <div class="form-group">
           <label>{{localize 'OSE.items.RollType'}}</label>
           <div class="form-fields">
             <select name="data.rollType">