Merge pull request #42 from thehappyanarchist/THA-Dev

Deploy 0.7.4

Changelog.txt

@@ -1,3 +1,11 @@
+**v0.7.4 Saving Throw bonus**
+**MINOR CHANGES:**
+Changed wording in settings menu to reflect that the Wisdom bonus applies to all saves is not a houserule, but an HFH option.
+HFH Option for wisdom bonuses to apply to all saves was only removing the "magic" button, now it applies the mod as well.
+
+**BUG FIXES:**
+Fixed wisdom bonus and penalties being swapped when rolling saves.
+
 **v0.7.3 Monster Ability Fix**
 **BUG FIXES:**
 Monster sheet was unable to add abilities.

README.md

@@ -18,14 +18,13 @@ ACKS, like most B/X clones, is also broadly compatible with thousands of modules
 - Pre-programmed saving throws for monsters based on HD
 - Auran setting languages in addition to standard tongues
 - Morale and Loyalty tracking for Henchmen
-- The ACKS Compendium has the majority of equipment, proficiencies, and spells from the Core Book.
+- The ACKS Compendium has the majority of equipment, proficiencies, and spells from the Core Book
 - ACKS Spellcasting, instead of Vancian
 - ACKS Core Treasure Tables by Bobloblah
 #### **Heroic Fantasy Handbook** (*optional*)
 - Added an option to use exploding 20s in combat from HFH optional rules  
-- Added an option to add Basic Healing Rate to the character sheet from HFH optional rules  
-#### **Houserules** (*optional*)
-- Added the popular wisdom bonus houserule to settings menu. Selecting it removes the prompt during rolling a save and declutters the Save vs Magic field from the sheet.
+- Added an option to calculate Basic Healing Rate on the character sheet
+- Added an option to apply wisdom bonus to all saves
 
 ## Manual Installation
 To install and use this system, simply paste the following URL into the Install System dialog on the Setup menu of the application.

src/lang/en.json

@@ -203,8 +203,8 @@
   "ACKS.Setting.Explode20Hint": "Heroic Fantasy Option: Attack throws explode on 20 - Critical if exceed target AC by 10",
   "ACKS.Setting.BHR": "HFH: Base Healing Rate",
   "ACKS.Setting.BHRHint": "Heroic Fantasy Option: Base Healing Rate per day varies by Max HP",
-  "ACKS.Setting.RemoveMagicBonus": "Houserule: Wisdom Bonus to All Saves",
-  "ACKS.Setting.RemoveMagicBonusHint": "A popular houserule, for use when PCs will add their wisdom modifier to all saving throws",
+  "ACKS.Setting.RemoveMagicBonus": "HFH: Wisdom Bonus to All Saves",
+  "ACKS.Setting.RemoveMagicBonusHint": "Heroic Fantasy Option: PCs will add their wisdom modifier to all saving throws, not just magic",
 
   "ACKS.items.Equip": "Equip",
   "ACKS.items.Unequip": "Unequip",

src/module/config.js

@@ -42,7 +42,7 @@ export const ACKS = {
     white: "ACKS.colors.white"
   },
   languages: [
-  "Northern",
+  "Common",
   "Jutlandic",
   "Auran",
   "Dwarvish",

src/module/dice.js

@@ -349,7 +349,7 @@ export class AcksDice {
           callback: (html) => {
             rolled = true;
             rollData.form = html[0].querySelector("form");
-            rollData.data.roll.target = parseInt(rollData.data.roll.target) + parseInt(rollData.data.roll.magic);
+            rollData.data.roll.target = parseInt(rollData.data.roll.target) - parseInt(rollData.data.roll.magic);
             rollData.title += ` ${game.i18n.localize("ACKS.saves.magic.short")} (${rollData.data.roll.magic})`;
             roll = AcksDice.sendRoll(rollData);
           },
@@ -367,7 +367,8 @@ export class AcksDice {
           icon: '<i class="fas fa-dice-d20"></i>',
           callback: (html) => {
             rolled = true;
-            rollData.form = html[0].children[0];
+            rollData.form = html[0].querySelector("form");
+            rollData.data.roll.target = parseInt(rollData.data.roll.target) - parseInt(rollData.data.roll.magic);
             roll = AcksDice.sendRoll(rollData);
           },
         },

src/system.json

@@ -2,7 +2,7 @@
   "name": "acks",
   "title": "Adventurer Conqueror King System",
   "description": "Play B/X or other OSR compatible content using the ACKS system",
-  "version": "0.7.3",
+  "version": "0.7.4",
   "minimumCoreVersion": "0.7.4",
   "compatibleCoreVersion": "0.7.5",
   "templateVersion": 2,
@@ -185,5 +185,5 @@
   "gridUnits": "ft",
   "url": "https://github.com/thehappyanarchist/foundryacks",
   "manifest": "https://github.com/thehappyanarchist/foundryacks/raw/master/src/system.json",
-  "download": "https://github.com/thehappyanarchist/foundryacks/raw/master/package/acks-v0.7.3.zip"
+  "download": "https://github.com/thehappyanarchist/foundryacks/raw/master/package/acks-v0.7.4.zip"
 }