0f897aea8f
Attempt to address intermittent s3 RequestTimeout error
...
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-23 20:07:32 -07:00
e6715c5cec
Attempt to address intermittent s3 RequestTimeout error
...
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-23 20:07:32 -07:00
0645327e71
Merge pull request #429 from stevvooe/correct-chunksize-check
...
Correctly check s3 chunksize parameter
2015-04-23 17:02:27 -07:00
c20417ce68
Merge pull request #429 from stevvooe/correct-chunksize-check
...
Correctly check s3 chunksize parameter
2015-04-23 17:02:27 -07:00
0d8cb4dca8
Correctly check s3 chunksize parameter
...
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-23 16:31:41 -07:00
6dd27cd2cb
Correctly check s3 chunksize parameter
...
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-23 16:31:41 -07:00
ea7d59ce2a
Merge pull request #428 from stevvooe/return-after-error
...
Return after error in handler
2015-04-23 14:01:25 -07:00
f40bf864b0
Merge pull request #428 from stevvooe/return-after-error
...
Return after error in handler
2015-04-23 14:01:25 -07:00
54aab2e9b8
Merge pull request #12417 from hashneo/patch-1
...
What if authConfig or factory is Nill?
2015-04-23 13:54:47 -07:00
8d4b636a60
Return after error in handler
...
This adds a missing return statement. It is not strictly needed since if the
io.Copy fails, the Finish operation will fail. Currently, the client reports
both errors where this new code will correctly only report the io.Copy error.
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-23 13:13:13 -07:00
f6d75a6139
Return after error in handler
...
This adds a missing return statement. It is not strictly needed since if the
io.Copy fails, the Finish operation will fail. Currently, the client reports
both errors where this new code will correctly only report the io.Copy error.
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-23 13:13:13 -07:00
a8b9bec104
Move CLI config processing out from under registry dir
...
No logic changes should be in here, just moving things around.
Signed-off-by: Doug Davis <dug@us.ibm.com>
2015-04-23 10:18:38 -07:00
ecda1f4eff
Include driver name in trace messsages
...
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-22 17:30:31 -07:00
d7eb17fd72
Include driver name in trace messsages
...
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-22 17:30:31 -07:00
b361b4811b
Require storage drivers to report their name
...
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-22 17:30:01 -07:00
9e146437e4
Require storage drivers to report their name
...
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-22 17:30:01 -07:00
73960f4024
Merge pull request #419 from stevvooe/pool-buffers-s3
...
Pool buffers used in S3.WriteStream
2015-04-22 16:41:28 -07:00
0281f4dce5
Merge pull request #419 from stevvooe/pool-buffers-s3
...
Pool buffers used in S3.WriteStream
2015-04-22 16:41:28 -07:00
1adab029f6
Pool buffers used in S3.WriteStream
...
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-22 16:25:53 -07:00
c49f7cd015
Pool buffers used in S3.WriteStream
...
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-22 16:25:53 -07:00
506a5b4a97
Merge pull request #418 from stevvooe/accept-chunksize-parameter
...
Allow configuration of chunksize parameter
2015-04-22 14:46:40 -07:00
0da2c631db
Merge pull request #418 from stevvooe/accept-chunksize-parameter
...
Allow configuration of chunksize parameter
2015-04-22 14:46:40 -07:00
72a702d0d9
Allow configuration of chunksize parameter
...
The code using values from the yaml package wasn't careful enought with the
possible incoming types. Turns out, it is just an int but we've made this
section somewhat bulletproof in case that package changes the behavior.
This code likely never worked. The configuration system should be decoupled
from the object instantiation.
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-22 14:31:34 -07:00
e4794ff73d
Allow configuration of chunksize parameter
...
The code using values from the yaml package wasn't careful enought with the
possible incoming types. Turns out, it is just an int but we've made this
section somewhat bulletproof in case that package changes the behavior.
This code likely never worked. The configuration system should be decoupled
from the object instantiation.
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-22 14:31:34 -07:00
cc1bd58d0f
Merge pull request #416 from stevvooe/remove-go13-test
...
Disable go1.3 tests for circle and upgrade to go1.4.2
2015-04-22 13:28:36 -07:00
cbfce39acb
Merge pull request #415 from stevvooe/update-goamz
...
Update goamz package dependency
2015-04-22 13:06:46 -07:00
36093aaf8b
Disable go1.3 tests for circle and upgrade to go1.4.2
...
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-22 12:57:22 -07:00
5faeddf8af
Merge pull request #414 from stevvooe/check-error-copy
...
Check error returned from io.Copy
2015-04-22 12:46:55 -07:00
e59046e598
Merge pull request #414 from stevvooe/check-error-copy
...
Check error returned from io.Copy
2015-04-22 12:46:55 -07:00
f1ea982e82
Check error returned from io.Copy
...
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-22 12:35:08 -07:00
4330627c71
Check error returned from io.Copy
...
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-22 12:35:08 -07:00
9bd1186654
Update goamz package dependency
...
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-22 12:32:59 -07:00
aa09c6c262
Merge pull request #408 from stevvooe/increase-retry-backoff
...
Backoff retry on verification to give s3 time to propagate
2015-04-21 13:19:28 -07:00
06fcc9213a
Merge pull request #408 from stevvooe/increase-retry-backoff
...
Backoff retry on verification to give s3 time to propagate
2015-04-21 13:19:28 -07:00
632e46418b
Backoff retry on verification to give s3 time to propagate
...
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-21 13:04:46 -07:00
36ffe0c134
Backoff retry on verification to give s3 time to propagate
...
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-21 13:04:46 -07:00
ad69b9d984
Merge pull request #407 from stevvooe/log-canonical-digest
...
log canonical digest on verification error
2015-04-21 13:03:32 -07:00
5f7693da80
Merge pull request #407 from stevvooe/log-canonical-digest
...
log canonical digest on verification error
2015-04-21 13:03:32 -07:00
d8dbcc3efa
log canonical digest on verification error
...
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-21 11:34:18 -07:00
77b30cfb25
log canonical digest on verification error
...
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-21 11:34:18 -07:00
1b975e980b
Merge pull request #405 from stevvooe/eventual-consistency
...
Attempt to deal with eventual consistency by retrying
2015-04-20 18:59:01 -07:00
4f41f0be06
Merge pull request #405 from stevvooe/eventual-consistency
...
Attempt to deal with eventual consistency by retrying
2015-04-20 18:59:01 -07:00
70e6ad6ef1
Merge pull request #404 from RichardScothern/digest-log
...
Add logging for generic handler errors.
2015-04-20 18:51:59 -07:00
85338448a3
Merge pull request #404 from RichardScothern/digest-log
...
Add logging for generic handler errors.
2015-04-20 18:51:59 -07:00
c8345090d9
Attempt to deal with eventual consistency by retrying
...
Rather than accept the resulting of a layer validation, we retry up to three
times, backing off 100ms after each try. The thought is that we allow s3 files
to make their way into the correct location increasing the liklihood the
verification can proceed, if possible.
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-20 18:49:22 -07:00
d4ce8f5ef8
Attempt to deal with eventual consistency by retrying
...
Rather than accept the resulting of a layer validation, we retry up to three
times, backing off 100ms after each try. The thought is that we allow s3 files
to make their way into the correct location increasing the liklihood the
verification can proceed, if possible.
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-04-20 18:49:22 -07:00
3a1029a262
Add logging for generic handler errors.
...
Signed-off-by: Richard Scothern <richard.scothern@gmail.com>
2015-04-20 17:47:52 -07:00
431811056b
Add logging for generic handler errors.
...
Signed-off-by: Richard Scothern <richard.scothern@gmail.com>
2015-04-20 17:47:52 -07:00
34d1494c7f
Make .docker dir have 0700 perms not 0600
...
Thanks to @dmcgowan for noticing.
Added a testcase to make sure Save() can create the dir and then
read from it.
Signed-off-by: Doug Davis <dug@us.ibm.com>
2015-04-20 14:16:50 -07:00
75e78e31de
Merge pull request #399 from stevvooe/response-writer-context
...
context: return instrumented response writer from context
2015-04-20 13:39:18 -07:00
Stephen J Day
Olivier Gambier
Jessie Frazelle
Doug Davis
Stephen Day
Richard