a837179414
Merge pull request #3072 from fermayo/fix-TestRegistryAsCacheMutationAPIs
...
Fix TestRegistryAsCacheMutationAPIs
2019-12-15 20:48:56 -08:00
6ca7b9e9fa
Fix TestRegistryAsCacheMutationAPIs
...
Use a synthetic upstream registry when creating the testing mirror configuration
to avoid the test fail when trying to reach http://example.com
Signed-off-by: Fernando Mayo Fernandez <fernando@undefinedlabs.com>
2019-12-15 13:51:25 +01:00
0f5e2753a6
Fix typo cloudfront updatefrenquency
...
Signed-off-by: Tom Hayward <thayward@infoblox.com>
2019-12-13 12:11:42 -08:00
bdf3438b52
Merge pull request #2985 from novas0x2a/default-transport
...
make it possible to wrap the client transport in another one
2019-12-13 11:36:12 -08:00
c9c3324300
Add unit tests for BlobEnumerator
...
Signed-off-by: Guillaume Rose <guillaume.rose@docker.com>
2019-12-06 09:38:13 +01:00
5538da4923
fixes to make layersPathSpec work
...
Signed-off-by: Guillaume Rose <guillaume.rose@docker.com>
2019-12-05 20:48:33 +01:00
fa7d949408
allow Repository.BlobStore to enumerate over blobs
...
Signed-off-by: Guillaume Rose <guillaume.rose@docker.com>
2019-12-05 20:48:33 +01:00
cf77113795
add pathspec for repo _layers directory
...
Signed-off-by: Guillaume Rose <guillaume.rose@docker.com>
2019-12-05 20:48:33 +01:00
ae2e973db9
Merge pull request #2748 from manishtomar/tag-digests
...
API to retrive tag's digests
2019-10-08 12:14:56 -07:00
f656e60de5
Merge pull request #2984 from bouk/rempo
...
registry: Fix typo in RepositoryRemover warning
2019-09-05 08:23:18 -07:00
740d4d1211
Merge pull request #2918 from dmathieu/test-blob-writer-write
...
Test httpBlobUpload.Write method
2019-09-05 08:16:36 -07:00
1c481d34d9
registry: Fix typo in RepositoryRemover warning
...
Signed-off-by: Bouke van der Bijl <me@bou.ke>
2019-09-02 16:07:34 +00:00
c486db2d71
make it possible to wrap the client transport in another one
...
Signed-off-by: Mike Lundy <mike@fluffypenguin.org>
2019-08-22 17:37:47 -04:00
1fb7fffdb2
Merge pull request #2950 from terinjokes/patches/swift-segment-hash
...
swift: correct segment path generation
2019-07-11 15:35:31 -07:00
dd3bdee21c
implement Repository Blobs upload resuming
...
Signed-off-by: Damien Mathieu <dmathieu@salesforce.com>
2019-06-26 09:46:49 +02:00
90dfea7952
Merge pull request #2921 from dmathieu/repository-serve-blob
...
Implement Repository ServeBlob
2019-06-25 19:07:38 -07:00
6c72ec2e85
Merge pull request #2927 from dmathieu/blob-create-uuid
...
Handle Blob Create when the underlying registry doesn't provide 'Docker-Upload-UUID'
2019-06-25 19:06:46 -07:00
898b1f2a53
test httpBlobUpload.Write method
...
Signed-off-by: Damien Mathieu <dmathieu@salesforce.com>
2019-06-25 09:32:58 +02:00
c5d5f938e3
fast-stop ServeBlob if we're doing a HEAD request
...
A registry pointing to ECR is having issues if we try loading the blob
Signed-off-by: Damien Mathieu <dmathieu@salesforce.com>
2019-06-25 09:30:22 +02:00
3800c47fd2
Implement Repository ServeBlob
...
Signed-off-by: Damien Mathieu <dmathieu@salesforce.com>
2019-06-25 09:30:22 +02:00
a45e5cb13f
handle create blob if the uuid couldn't be retrieved from headers or URL
...
Signed-off-by: Damien Mathieu <dmathieu@salesforce.com>
2019-06-25 09:29:38 +02:00
8b31a894bd
deduce blob UUID from location if it wasn't provided in the headers
...
Some registries (ECR) don't provide a `Docker-Upload-UUID` when creating
a blob. So we can't rely on that header. Fallback to reading it from the
URL.
Signed-off-by: Damien Mathieu <dmathieu@salesforce.com>
2019-06-25 09:29:38 +02:00
94097512db
extract blob upload resume into its own method
...
I've found this logic being in a single method to be quite hard to get.
I believe extracting it makes it easier to read, as we can then more
easily see what the main method does and possibly ignore the intricacies
of `ResumeBlobUpload`.
Signed-off-by: Damien Mathieu <dmathieu@salesforce.com>
2019-06-25 09:25:56 +02:00
b23dd1ef37
swift: correct segment path generation
...
When uploading segments to Swift, the registry generates a random file,
by taking the hash of the container path and 32-bytes of random data.
The registry attempts to shard across multiple directory paths, by
taking the first three hex characters as leader.
The implementation in registry, unfortunately, takes the hash of
nothing, and appends it to the path and random data. This results in all
segments being created in one directory.
Fixes : #2407
Fixes : #2311
Signed-off-by: Terin Stock <terinjokes@gmail.com>
2019-06-22 23:44:43 -07:00
84f47e7bb3
Merge pull request #2900 from sevki/no-token-err-fix
...
fix no error returned in fetchTokenWithOAuth
2019-06-19 19:16:18 -07:00
6c329e56a2
Merge pull request #2920 from dmathieu/blob_writer_offset
...
Append the written bytes to the blob writer's size
2019-06-19 19:14:49 -07:00
0c394fdd84
Merge pull request #2861 from yuwaMSFT2/master
...
Fixes #2835 Process Accept header MIME types in case-insensitive way
2019-06-19 19:09:29 -07:00
d80a17d8e0
Merge pull request #2879 from tbe/fix-s3-ceph
...
Fix s3 driver for supporting ceph radosgw
2019-06-19 19:09:07 -07:00
55287010ce
Merge pull request #2894 from jabrown85/fix-offset-typos
...
Fix typo: offest -> offset
2019-06-19 19:08:22 -07:00
8f9c8094fb
replace rsc.io/letsencrypt in favour of golang.org/x/crypto
...
Signed-off-by: Tariq Ibrahim <tariq181290@gmail.com>
2019-06-04 12:04:18 -07:00
0e2d080a8a
append the written bytes to the blob writer's size
...
Any byte written should append to the size. Otherwise, the full Size is
always zero.
Signed-off-by: Damien Mathieu <dmathieu@salesforce.com>
2019-05-09 14:17:58 +02:00
3226863cbc
Merge pull request #2849 from Shawnpku/master
...
support Alibaba Cloud CDN storage middleware
2019-04-16 18:43:06 -07:00
5afbf32400
fix no error returned in fetchTokenWithOAuth
...
fetchTokenWithBasicAuth checks if a token is in the token response
but fetchTokenWithOAuth does not
these changes implements the same behaviour for the latter
returning a `ErrNoToken` if a token is not found in the resposne
Signed-off-by: Sevki Hasirci <sevki@cloudflare.com>
2019-04-14 11:05:59 +01:00
74f429a5ad
Fix typo: offest -> offset
...
Signed-off-by: Jesse Brown <jabrown85@gmail.com>
2019-04-05 14:20:20 -05:00
fd77cf43a6
change package name & format document
...
Signed-off-by: Shawn Chen <chen8132@gmail.com>
2019-03-18 11:35:46 +08:00
c18c6c33b2
S3 Driver: added comment for missing KeyCount workaround
...
Signed-off-by: Thomas Berger <loki@lokis-chaos.de>
2019-03-15 21:05:21 +01:00
f877726503
Fix s3 driver for supporting ceph radosgw
...
Radosgw does not support S3 `GET Bucket` API v2 API but v1.
This API has backward compatibility, so most of this API is working
correctly but we can not get `KeyCount` in v1 API and which is only
for v2 API.
Signed-off-by: Eohyung Lee <liquidnuker@gmail.com>
2019-03-08 12:45:20 +01:00
3390f32aec
fix Context issue
...
Signed-off-by: Shawn Chen <chen8132@gmail.com>
2019-03-04 17:48:32 +08:00
6e10631d9c
fix default cdn auth duration
...
Signed-off-by: Shawnpku <chen8132@gmail.com>
2019-03-04 14:53:48 +08:00
f9a0506191
Bugfix: Make ipfilteredby not required
...
Signed-off-by: Vishesh Jindal <vishesh92@gmail.com>
2019-03-02 08:58:52 +05:30
d3ddc3572c
Merge pull request #2854 from manishtomar/log-authed-name
...
Log authorized username
2019-03-01 14:45:43 -08:00
c192a281f8
Merge pull request #2813 from lucab/ups/spec-json-binary
...
registry: fix binary JSON content-type
2019-03-01 14:26:54 -08:00
a683c7c235
Fixes #2835 Process Accept header MIME types in case-insensitive way
...
Use mime.ParseMediaType to parse the media types in Accept header in manifest request. Ignore the failed ones.
Signed-off-by: Yu Wang <yuwa@microsoft.com>
2019-02-21 15:11:41 -08:00
bbc9885aa2
fix func name
...
Signed-off-by: Shawnpku <chen8132@gmail.com>
2019-02-20 15:54:21 +08:00
ec6566c02b
Log authorized username
...
This is useful to know which user pulled/pushed which repo.
Signed-off-by: Manish Tomar <manish.tomar@docker.com>
2019-02-13 08:49:37 -08:00
3aa2a282f7
support alicdn middleware
...
Signed-off-by: Shawnpku <chen8132@gmail.com>
2019-02-11 15:11:26 +08:00
48818fdea7
Remove err nil check
...
since type checking nil will not panic and return appropriately
Signed-off-by: Manish Tomar <manish.tomar@docker.com>
2019-02-04 16:42:44 -08:00
da8db4666b
Fix gometalint errors
...
Signed-off-by: Manish Tomar <manish.tomar@docker.com>
2019-02-04 16:01:04 -08:00
b75069ef13
Merge pull request #2791 from AliyunContainerService/support-oss-byok
...
Support BYOK for OSS storage driver
2019-01-16 16:37:37 -08:00
bda79219b2
Add code to handle pagination of parts. Fixes max layer size of 10GB bug
...
Signed-off-by: Jack Baines <jack.baines@uk.ibm.com>
2019-01-14 14:54:55 +00:00
15b0204758
registry: fix binary JSON content-type
...
This fixes registry endpoints to return the proper `application/json`
content-type for JSON content, also updating spec examples for that.
As per IETF specification and IANA registry [0], the `application/json`
type is a binary media, so the content-type label does not need any
text-charset selector. Additionally, the media type definition
explicitly states that it has no required nor optional parameters,
which makes the current registry headers non-compliant.
[0]: https://www.iana.org/assignments/media-types/application/json
Signed-off-by: Luca Bruno <lucab@debian.org>
2019-01-14 09:04:42 +00:00
cdb62b2b77
Registry - make minimum TLS version user configurable
...
Signed-off-by: J. Gregory Rebholz <gregrebholz@gmail.com>
2019-01-11 18:11:03 -05:00
eb1a2cd911
default autoredirect to false
...
Signed-off-by: David Wu <david.wu@docker.com>
2019-01-04 11:05:12 -08:00
90bed67126
Support BYOK for OSS storage driver
...
Change-Id: I423ad03e63bd38aded3abfcba49079ff2fbb3b74
Signed-off-by: Li Yi <denverdino@gmail.com>
2018-12-25 08:30:40 +08:00
aa985ba889
Merge pull request #2711 from davidswu/autoredirect
...
add autoredirect auth config
2018-11-27 15:48:25 -08:00
1251e51ad0
better name and updated tests
...
- use ManifestDigests name instead of Indexes
- update tests to validate against multiple tags
Signed-off-by: Manish Tomar <manish.tomar@docker.com>
2018-11-01 10:31:08 -07:00
9ebf151ac2
API to retrive tag's digests
...
Add an interface alongside TagStore that provides API to retreive
digests of all manifests that a tag historically pointed to. It also
includes currently linked tag.
Signed-off-by: Manish Tomar <manish.tomar@docker.com>
2018-10-29 18:19:05 -07:00
7c4d584e58
add bugsnag logrus hook
...
Signed-off-by: Matt Tescher <matthew.tescher@docker.com>
2018-10-25 14:52:10 -07:00
de8636b78c
typo fix about overridden
...
Signed-off-by: Yongxin Li <yxli@alauda.io>
2018-09-27 20:27:09 +08:00
569d18aef9
Fix some typos
...
Signed-off-by: Rui Cao <ruicao@alauda.io>
2018-09-24 09:05:44 +08:00
2e1e6307dd
add autoredirect to option
...
Signed-off-by: David Wu <david.wu@docker.com>
2018-09-20 19:33:06 -07:00
b2bd465760
fix checks
...
Signed-off-by: David Wu <david.wu@docker.com>
2018-09-20 15:24:27 -07:00
f730f3ab77
add autoredirect auth config
...
It redirects the user to to the Host header's domain whenever they try to use
token auth.
Signed-off-by: David Wu <david.wu@docker.com>
2018-09-20 14:47:43 -07:00
16128bbac4
Merge pull request #2707 from davidswu/go-1.11
...
remove dependencies on resumable
2018-09-20 12:47:44 -07:00
6133840f49
typo fix from existant to existent
...
Signed-off-by: liyongxin <yxli@alauda.io>
Signed-off-by: Yongxin Li <yxli@alauda.io>
2018-09-13 19:37:13 +08:00
a927fbdb9b
track digest offset in blobwriter
...
Signed-off-by: David Wu <david.wu@docker.com>
2018-09-12 14:53:27 -07:00
bd41413d57
remove closenotifier
...
Signed-off-by: David Wu <david.wu@docker.com>
2018-09-11 16:14:10 -07:00
166874ade9
fix gofmt and goimports
...
Signed-off-by: David Wu <david.wu@docker.com>
2018-09-11 16:14:10 -07:00
877d706b38
remove dependencies on resumable
...
Signed-off-by: David Wu <david.wu@docker.com>
2018-09-11 08:21:27 -07:00
642075f42c
Merge pull request #2631 from whoshuu/feature/improve-gcs-driver
...
Improve gcs driver
2018-09-05 17:48:03 -07:00
15de837aa8
Merge pull request #2704 from dmcgowan/fix-2703
...
Fix registry stripping newlines from manifests
2018-09-05 17:46:56 -07:00
7a195dd5ca
Add back include_gcs build constraint
...
Signed-off-by: Huu Nguyen <whoshuu@gmail.com>
2018-09-05 15:48:30 -07:00
69299d93d9
Use existing jwtConf instead of creating a scoped one
...
Signed-off-by: Huu Nguyen <whoshuu@gmail.com>
2018-09-05 15:48:30 -07:00
f9187b2572
Add regulator to GCS
...
Signed-off-by: Huu Nguyen <whoshuu@gmail.com>
2018-09-05 15:48:30 -07:00
b424c3d870
Better error handling for GCS credential argument addition
...
Signed-off-by: Andrey Kostov <kostov.andrey@gmail.com>
2018-09-05 15:48:29 -07:00
78238ef1a0
Add credentials argument for GCS driver
...
Signed-off-by: Andrey Kostov <kostov.andrey@gmail.com>
2018-09-05 15:48:29 -07:00
c88728f217
Fix registry stripping newlines from manifests
...
Content must be preserved exactly
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
2018-09-05 13:40:42 -07:00
6b73a9ab89
Ignore missing paths during enumeration
...
It's possible to run into a race condition in which the enumerator lists
lots of repositories and then starts the long process of enumerating through
them. In that time if someone deletes a repo, the enumerator may error out.
Signed-off-by: Ryan Abrams <rdabrams@gmail.com>
2018-09-05 10:17:08 -07:00
8d7e4cd388
fix goimports and gofmt
...
Signed-off-by: David Wu <david.wu@docker.com>
2018-09-04 17:45:39 -07:00
90705d2fb8
Merge pull request #2362 from twistlock/populate_htpasswd
...
Create and populate htpasswd file if missing
2018-08-31 00:25:37 -07:00
b12bd4004a
Merge pull request #2639 from andrew-leung/manifesteventlayers
...
Add configurable layers in manifest events
2018-08-28 16:03:05 -07:00
059f301d54
Merge pull request #2685 from manishtomar/mani-graceful-shutdown
...
Graceful shutdown
2018-08-27 14:24:53 -07:00
3354cf98e3
Merge pull request #2680 from manishtomar/mani-fix-mem-leak
...
fix memory leak introduced in PR #2648
2018-08-24 14:35:12 -07:00
ef859e1b21
Merge pull request #2474 from vikstrous/disable-v1-master
...
disable schema1 by default, add a config flag to enable it
2018-08-24 10:58:39 -07:00
53bd46af5c
Merge pull request #2651 from mikebrow/manifest-version-test-on-put
...
adds validation testing for schema version values
2018-08-20 12:19:40 -07:00
6411087274
Merge pull request #2681 from dmcgowan/update-yaml
...
Update yaml parser
2018-08-20 12:18:21 -07:00
0b0d470281
use aws sdk to validate regions
...
Signed-off-by: David Wu <david.wu@docker.com>
2018-08-20 11:02:14 -07:00
5e4b81a578
Use references terminology instead of layers.
...
Signed-off-by: Andrew Leung <anwleung@gmail.com>
2018-08-20 10:01:40 -07:00
40efb602d6
Add support to gracefully shutdown the server
...
This is done by draining the connections for configured time after registry receives a SIGTERM signal.
This adds a `draintimeout` setting under `HTTP`. Registry doesn't drain
if draintimeout is not provided.
Signed-off-by: Manish Tomar <manish.tomar@docker.com>
2018-08-20 10:01:26 -07:00
f0ee5720a5
Update yaml parser
...
Mark the top level Loglevel field as deprecated
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
2018-08-14 16:42:36 -07:00
13f8189f2a
fix memory leak introduced in PR #2648
...
context.App.repoRemover is single registry instance stored throughout
app run. It was wrapped in another remover when processing each request.
This remover happened to be remover got from previous request. This way
every remover created was stored in infinite linked list causing memory
leak. Fixing it by storing the wrapped remover inside the request context
which will get gced when request context is gced. This was introduced in
PR #2648 .
Signed-off-by: Manish Tomar <manish.tomar@docker.com>
2018-08-14 16:41:45 -07:00
2fdb2ac270
adds validation testing for schema version values
...
Signed-off-by: Mike Brown <brownwm@us.ibm.com>
2018-08-14 08:53:54 -05:00
5f37adaa41
Merge pull request #2673 from dmp42/TLS
...
Remove ciphers that do not support perfect forward secrecy
2018-08-10 16:03:59 -07:00
88530ef7a0
Merge pull request #2671 from dmp42/goamz
...
Remove goamz
2018-08-10 15:54:04 -07:00
7d9f067716
Merge pull request #2632 from whoshuu/feature/improve-s3-driver
...
Improve s3 driver
2018-08-10 15:01:11 -07:00
d260b18f2f
Remove ciphers that do not support perfect forward secrecy
...
Signed-off-by: Olivier <o+github@gambier.email>
2018-08-10 14:58:51 -07:00
9caa7a81bc
Remove goamz
...
Signed-off-by: Olivier <o+github@gambier.email>
2018-08-10 11:11:53 -07:00
b7446e89bf
Merge pull request #2599 from legionus/storage-inmemory-deadlock
...
Fix deadlock in the inmemory storage driver
2018-08-09 15:26:12 -07:00
0cbe144826
Merge pull request #2602 from dmage/errmessage
...
Use e.Message field instead of e.Code.Message()
2018-08-09 15:21:32 -07:00
4a75b72fd3
Merge pull request #2662 from dmcgowan/enable-structcheck
...
Enable static checks
2018-08-07 19:01:38 -07:00
eefe9670bd
Merge pull request #2661 from dmcgowan/enable-goimports
...
Enable goimports check
2018-08-07 14:59:49 -07:00
003aa051b4
Merge pull request #2648 from manishtomar/tag-deleted-event
...
add repo and tag deletion event
2018-08-07 11:50:56 -07:00
db0a4ec1c8
Enable static checks
...
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
2018-08-06 14:49:11 -07:00
795e11d5fb
Enable goimports check
...
Validates that goimports has been run on all files
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
2018-08-06 14:37:44 -07:00
32e2260be2
Enable struct check
...
Signed-off-by: Derek McGowan <derek@mcgstyle.net>
2018-08-06 13:55:43 -07:00
8c05756141
lint fix
...
Signed-off-by: Manish Tomar <manish.tomar@docker.com>
2018-08-06 09:46:42 -07:00
8f6758278d
take handler update
...
forgot to commit this earlier
Signed-off-by: Manish Tomar <manish.tomar@docker.com>
2018-08-02 23:13:37 -07:00
328069bb4d
add support for repo deleted event also
...
by having another interface RepositoryRemover that is implemented by
registry instance and is injected in app context for event tracking
Signed-off-by: Manish Tomar <manish.tomar@docker.com>
2018-08-02 23:05:05 -07:00
20aecf1d7b
added test for initial oci schema version
...
Signed-off-by: Mike Brown <brownwm@us.ibm.com>
2018-07-19 19:41:31 -05:00
5f588fbf9b
address review comment regarding panic use
...
Signed-off-by: Mike Brown <brownwm@us.ibm.com>
2018-07-19 16:07:26 -05:00
276fdce3d9
Add configurable layers in manifest events
...
Signed-off-by: Andrew Leung <anwleung@gmail.com>
2018-06-27 09:27:24 -07:00
e8d7941ca6
address lint and gofmt issues
...
Signed-off-by: Mike Brown <brownwm@us.ibm.com>
2018-06-25 15:45:15 -05:00
f5c6357c6d
Update s3_test to account for SkipVerify parameter
...
Signed-off-by: Huu Nguyen <whoshuu@gmail.com>
2018-06-22 12:00:28 -07:00
7655a3d91f
Add option to skip certificate verification for the s3 driver
...
Signed-off-by: Huu Nguyen <whoshuu@gmail.com>
2018-06-22 12:00:21 -07:00
132abc6de5
Test storing OCI image manifests and indexes with/without a media type
...
OCI Image manifests and indexes are supported both with and without
an embeded MediaType (the field is reserved according to the spec).
Test storing and retrieving both types from the manifest store.
Signed-off-by: Owen W. Taylor <otaylor@fishsoup.net>
2018-06-19 11:24:25 -04:00
60d9c5dfad
Handle OCI manifests and image indexes without a media type
...
In the OCI image specification, the MediaType field is reserved
and otherwise undefined; assume that manifests without a media
in storage are OCI images or image indexes, and determine which
by looking at what fields are in the JSON. We do keep a check
that when unmarshalling an OCI image or image index, if it has
a MediaType field, it must match that media type of the upload.
Signed-off-by: Owen W. Taylor <otaylor@fishsoup.net>
2018-06-19 11:24:25 -04:00
ad7ab0853c
folow commit 9c88801a12
...
Signed-off-by: Mike Brown <brownwm@us.ibm.com>
2018-06-18 13:55:24 -05:00
7b47fb13cf
update url policy support; testing for annoations in index
...
Signed-off-by: Mike Brown <brownwm@us.ibm.com>
2018-06-18 13:55:24 -05:00
ec2aa05cdf
addressing comments from stevvooe
...
Signed-off-by: Mike Brown <brownwm@us.ibm.com>
2018-06-18 13:55:24 -05:00
6bae7ca597
refactor adding enum for storage types
...
Signed-off-by: Mike Brown <brownwm@us.ibm.com>
2018-06-18 13:55:24 -05:00
9e3f78b8c8
addresses minor debug comments
...
Signed-off-by: Mike Brown <brownwm@us.ibm.com>
2018-06-18 13:55:24 -05:00
b0cef05626
removes oci. namespace feature
...
Signed-off-by: Mike Brown <brownwm@us.ibm.com>
2018-06-18 13:55:24 -05:00
426afb3a4c
address get manifest issue with oci. namespace; and comment descriptions
...
Signed-off-by: Mike Brown <brownwm@us.ibm.com>
2018-06-18 13:55:24 -05:00
c94f28805e
OCI media types; annotation support; oci index
...
Signed-off-by: Mike Brown <brownwm@us.ibm.com>
2018-06-18 13:48:58 -05:00
6fcea22b0a
add an ocischema manifest handler for the registry
...
Signed-off-by: Mike Brown <brownwm@us.ibm.com>
2018-06-18 13:48:58 -05:00
9986e8ca7c
adds support for oci manifests and manifestlists
...
Signed-off-by: Mike Brown <brownwm@us.ibm.com>
2018-06-18 13:48:58 -05:00
62797237b9
closes #2496 and #2552
...
Update Azure SDK with release v16.2.1
Update Azure autorest SDK with release v10.8.1
Signed-off-by: Yu Wang <yuwa@microsoft.com>
2018-06-08 16:53:02 -07:00
7bc438a534
Use e.Message field instead of e.Code.Message()
...
Signed-off-by: Oleg Bulatov <oleg@bulatov.me>
2018-06-04 17:29:46 +02:00
fc7e8f42d7
Fix deadlock in the inmemory storage driver
...
According golang documentation [1]: no goroutine should expect to be
able to acquire a read lock until the initial read lock is released.
[1] https://golang.org/pkg/sync/#RWMutex
Signed-off-by: Gladkov Alexey <agladkov@redhat.com>
2018-05-30 18:01:08 +02:00
23bef416bd
Merge pull request #2538 from tianon/challanges
...
Fix minor "Challanges" typo
2018-03-21 09:58:14 -07:00
607ae5d128
Merge pull request #2501 from xiaonancc77/master
...
Added ignore event types into notifications
2018-03-14 10:37:02 -07:00
492844e09c
redis: delete right size attribute
...
Signed-off-by: Michal Minář <miminar@redhat.com>
2018-03-13 15:25:32 +01:00
fc1d3647c6
Added ignore event typs into notifications
...
Signed-off-by: elsanli(李楠) <elsanli@tencent.com>
2018-03-13 16:00:44 +08:00
f2805894c8
Fix minor "Challanges" typo
...
Signed-off-by: Tianon Gravi <admwiggin@gmail.com>
2018-03-01 11:25:05 -08:00
6664ec7039
Merge pull request #2466 from tifayuki/prometheus_go_metrics
...
add prometheus metrics
2018-02-09 15:49:04 -08:00
e3c37a46e2
Add Prometheus Metrics
...
at the first iteration, only the following metrics are collected:
- HTTP metrics of each API endpoint
- cache counter for request/hit/miss
- histogram of storage actions, including:
GetContent, PutContent, Stat, List, Move, and Delete
Signed-off-by: tifayuki <tifayuki@gmail.com>
2018-02-09 14:27:51 -08:00
13076371a6
Merge pull request #2520 from ywk253100/ignore_path_not_found_error
...
Ignore path not found error when look up tags
2018-02-09 11:19:52 -08:00
005c6e0236
ignore path not found error when look up tags
...
Signed-off-by: Wenkai Yin <yinw@vmware.com>
2018-02-08 17:32:25 +08:00
d707ea2428
Merge pull request #2469 from felixbuenemann/letsencrypt-host-whitelist-support
...
Let's Encrypt Host Whitelist Support
2018-02-06 16:11:20 -08:00
1ba5b3b553
registry/storage: ignore missing tag on delete
...
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2018-02-06 15:25:51 -08:00
fea8bd5114
Merge pull request #2471 from GarageDeveloper/master
...
fixes #2249 : sanitize tenant and tenantid
2018-02-02 16:29:34 -08:00
4ecb17cc4c
registry: support whitelisting letsencrypt hosts
...
This adds a configuration setting `HTTP.TLS.LetsEncrypt.Hosts` which can
be set to a list of hosts that the registry will whitelist for retrieving
certificates from Let's Encrypt. HTTPS connections with SNI hostnames
that are not whitelisted will be closed with an "unknown host" error.
It is required to avoid lots of unsuccessful registrations attempts that
are triggered by malicious clients connecting with bogus SNI hostnames.
NOTE: Due to a bug in the deprecated vendored rsc.io/letsencrypt library
clearing the host list requires deleting or editing of the cachefile to
reset the hosts list to null.
Signed-off-by: Felix Buenemann <felix.buenemann@gmail.com>
2018-02-01 21:16:58 +01:00
5cb406d511
Merge pull request #2455 from sargun/make-walk-faster
...
s3: improve walk performance
2018-01-19 13:00:03 -08:00
cbcbcb02c5
Remove old walk function
...
This removes the old global walk function, and changes all
the code to use the per-driver walk functions.
Signed-off-by: Sargun Dhillon <sargun@sargun.me>
2018-01-18 13:06:07 -08:00
c7b0da2622
Use the new walk method for catalog enumeration
...
This change is primarily to make GC faster.
Signed-off-by: Sargun Dhillon <sargun@sargun.me>
2018-01-18 11:58:46 -08:00
585cdeb571
context, registry/handlers: remove net/context references
...
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2018-01-17 16:01:41 -08:00
35b29a609e
Use the New Driver Walk method for catalog enumeration
...
This changes the Walk Method used for catalog enumeration. Just to show
how much an effect this has on our s3 storage:
Original:
List calls: 6839
real 3m16.636s
user 0m0.000s
sys 0m0.016s
New:
ListObjectsV2 Calls: 1805
real 0m49.970s
user 0m0.008s
sys 0m0.000s
This is because it no longer performs a list and stat per item, and instead
is able to use the metadata gained from the list as a replacement to stat.
Signed-off-by: Sargun Dhillon <sargun@sargun.me>
2018-01-07 22:45:17 -08:00
32ac467992
Introduce Walk Method Per Storage Driver
...
Move the Walk types into registry/storage/driver, and add a Walk method to each
storage driver. Although this is yet another API to implement, there is a fall
back implementation that relies on List and Stat. For some filesystems this is
very slow.
Also, this WalkDir Method conforms better do a traditional WalkDir (a la filepath).
This change is in preparation for refactoring.
Signed-off-by: Sargun Dhillon <sargun@sargun.me>
2018-01-07 22:45:17 -08:00
ff87ad884c
add possibility to clean untagged manifests
...
add tests
add possibility to clean untagged manifests
Signed-off-by: Jesse Haka <haka.jesse@gmail.com>
add dry tests
Signed-off-by: Jesse Haka <haka.jesse@gmail.com>
remove underscores
Signed-off-by: Jesse Haka <haka.jesse@gmail.com>
fixes
Signed-off-by: Jesse Haka <haka.jesse@gmail.com>
opts struct+use camelcase
Signed-off-by: Jesse Haka <haka.jesse@gmail.com>
doublecheck manifest in paths.go
Signed-off-by: Jesse Haka <haka.jesse@gmail.com>
add gofmt
Signed-off-by: Jesse Haka <haka.jesse@gmail.com>
fix lint
Signed-off-by: Jesse Haka <haka.jesse@gmail.com>
add log print
Signed-off-by: Jesse Haka <haka.jesse@gmail.com>
move log to dryrun as well
Signed-off-by: Jesse Haka <haka.jesse@gmail.com>
remove counter
Signed-off-by: Jesse Haka <haka.jesse@gmail.com>
remove manifest tag references
Signed-off-by: Jesse Haka <haka.jesse@gmail.com>
add tag to tests
Signed-off-by: Jesse Haka <haka.jesse@gmail.com>
manifestsWithoutTags -> removeUntagged
Signed-off-by: Jesse Haka <haka.jesse@gmail.com>
remove RemoveManifestTagReferences and use removemanifests
Signed-off-by: Jesse Haka <haka.jesse@gmail.com>
remove comment
Signed-off-by: Jesse Haka <haka.jesse@gmail.com>
remove pathfor
Signed-off-by: Jesse Haka <haka.jesse@gmail.com>
move removemanifest out of manifestenumerator, it does not work correctly if we delete stuff in it
Signed-off-by: Jesse Haka <haka.jesse@gmail.com>
add comment
Signed-off-by: Jesse Haka <haka.jesse@gmail.com>
fix context -> dcontext
Signed-off-by: Jesse Haka <haka.jesse@gmail.com>
fix gofmt
2018-01-05 12:20:01 +02:00
e9864ce8b9
disable schema1 by default, add a config flag to enable it
...
port of #2473
Signed-off-by: Viktor Stanchev <me@viktorstanchev.com>
2017-12-19 10:23:25 -08:00
Derek McGowan
Fernando Mayo Fernandez
Tom Hayward
Guillaume Rose
Manish Tomar
Ryan Abrams
Bouke van der Bijl
Mike Lundy
Damien Mathieu
Terin Stock
Tariq Ibrahim
Sevki Hasirci
Jesse Brown
Shawn Chen
Thomas Berger
Eohyung Lee
Vishesh Jindal
Yu Wang
Jack Baines
Luca Bruno
Greg Rebholz
David Wu
Li Yi
Matt Tescher
Yongxin Li
Rui Cao
Viktor Stanchev
Olivier Gambier
Huu Nguyen
Tony Holdstock-Brown
Andrey Kostov
Andrew Leung
Manish Tomar
Mike Brown
Olivier
dmp
Owen W. Taylor
Oleg Bulatov
Gladkov Alexey
Michal Minář
elsanli(李楠)
Tianon Gravi
Stephen Day
tifayuki
Wenkai Yin
Stephen J Day
Felix Bünemann
Sargun Dhillon
Jesse Haka