d2f7d65d71
Don't return req as result of setTokenAuth
2013-12-03 16:32:13 +01:00
1ff180d1b4
missed one call to setTokenAuth
2013-12-03 16:32:13 +01:00
0fca0f12f6
Factorized auth token setting
2013-12-03 16:32:13 +01:00
d4a00ebecb
gofmt
2013-12-03 16:32:13 +01:00
097f41245a
Use basic auth for private registries when over HTTPS.
...
RequestFactory is no longer a singleton (can be different for different instances of Registry)
Registry now has an indexEndpoint member
Registry methods that needed the indexEndpoint parameter no longer do so
Registry methods will only use token auth where applicable if basic auth is not enabled.
2013-12-03 16:32:13 +01:00
52a0a052e8
go fmt.
...
result of `gofmt -w -s .` without vendors.
2013-11-29 22:20:59 -02:00
c86cee210f
Closing connection after ping
2013-11-29 12:07:20 +00:00
2c26420bc4
update docker search to reflect future changes of the api
2013-10-31 19:14:11 -07:00
77f6f32704
Removes \\n from debugf calls
2013-10-25 17:50:40 -07:00
2f94790d67
registry: fix content-type for PushImageJSONIndex
2013-10-22 11:56:48 -07:00
8d77082c92
Fix some error cases where a HTTP body might not be closed
...
Refs #2126
2013-10-08 15:35:00 -04:00
cbb906e41f
fix the error message so it is the same as the regex issue #1999
2013-09-25 11:33:09 -04:00
9c366e092d
Modify repository name regex to match index
2013-09-19 20:25:00 -07:00
49736d5fc7
Prevent panic upon error pulling registry
2013-09-16 16:18:25 -07:00
ee38e49093
Login against private registry
...
To improve the use of docker with a private registry the login
command is extended with a parameter for the server address.
While implementing i noticed that two problems hindered authentication to a
private registry:
1. the resolve of the authentication did not match during push
because the looked up key was for example localhost:8080 but
the stored one would have been https://localhost:8080
Besides The lookup needs to still work if the https->http fallback
is used
2. During pull of an image no authentication is sent, which
means all repositories are expected to be private.
These points are fixed now. The changes are implemented in
a way to be compatible to existing behavior both in the
API as also with the private registry.
Update:
- login does not require the full url any more, you can login
to the repository prefix:
example:
docker logon localhost:8080
Fixed corner corner cases:
- When login is done during pull and push the registry endpoint is used and
not the central index
- When Remote sends a 401 during pull, it is now correctly delegating to
CmdLogin
- After a Login is done pull and push are using the newly entered login data,
and not the previous ones. This one seems to be also broken in master, too.
- Auth config is now transfered in a parameter instead of the body when
/images/create is called.
2013-09-03 20:45:49 +02:00
a7b3e7eb78
registry: removing opaqueRequest
2013-08-16 19:33:59 +02:00
ecd70a1948
hot fix display in parallel pull and go fmt
2013-08-15 11:42:40 +00:00
e55267bc99
Add GitHub usernames to MAINTAINERS
2013-08-09 21:16:44 -04:00
856fce8c2c
Merge pull request #1481 from titanous/fix-sprint
...
Fix typo: fmt.Sprint -> fmt.Sprintf
2013-08-09 17:28:59 -07:00
42b6e56d19
Fix typo: fmt.Sprint -> fmt.Sprintf
2013-08-09 19:52:05 -04:00
3fdac42b99
Merge pull request #1362 from dotcloud/registry_test
...
* Registry: Registry unit tests + mock registry
2013-08-07 15:30:07 -07:00
f1ead19f3f
Merge pull request #1406 from dotcloud/1363-reduce_timeout-fix
...
Reduce connect and read timeout when pinging the registry (fixes issue #1363 )
2013-08-06 04:22:44 -07:00
03c1bbbf65
Adapted tests to latest registry changes
2013-08-05 20:28:05 +02:00
5ea461f300
Cleanup
2013-08-05 19:07:23 +02:00
da046e945f
Mock access logs don't show up in non-debug mode
2013-08-05 19:06:00 +02:00
7c3b31e5d4
gofmt
2013-08-05 19:06:00 +02:00
4d9dcc3cba
New registry unit tests remade from scratch, using the mock registry
2013-08-05 19:06:00 +02:00
93877a859a
Mock registry: Fixed a bug where the index validation path would return a 200 status code instead of the expected 204
2013-08-05 19:06:00 +02:00
04cbff8d35
registry: Fixed a bug where token and cookie info wouldn't be sent when using LookupRemoteImage(). Fixed a bug where no error would be reported when getting a non-200 status code in GetRemoteImageLayer()
2013-08-05 19:05:14 +02:00
28f0f0ffb8
Disabled test server in the tests
2013-08-05 19:02:57 +02:00
34fc4b8407
Mocked registry: Added X-Docker-Size when fetching the layer
2013-08-05 19:02:57 +02:00
3ca4529fbe
Fixed mocked registry
2013-08-05 19:02:57 +02:00
14cc9fcfda
Implemented a Mocked version of the Registry server
2013-08-05 19:02:57 +02:00
0e12ec253d
Merge pull request #1408 from dotcloud/1407-localhost_is_a_domain-fix
...
Always consider localhost as a domain name when parsing the FQN repos name
2013-08-05 08:50:12 -07:00
67be3be855
Merge pull request #1382 from monnand/650-http-utils
...
650 http utils and user agent field
2013-08-05 08:49:12 -07:00
fec63826b9
Always consider localhost as a domain name when parsing the FQN repos name
2013-08-04 17:59:12 -07:00
1fe03a4bf7
Reduce connect and read timeout when pinging the registry (fixes issue #1363 )
2013-08-04 17:42:24 -07:00
95b4a0c32a
Return JSONError for HTTPResponse error
2013-08-03 00:27:58 +00:00
762dfbfced
reqFactory in Registry
2013-08-02 03:08:08 -04:00
11cd5760f9
Return registy status code in error
...
Added Details map to the JSONMessage
2013-07-30 23:24:31 +00:00
0b59dcfa2d
Make sure the index also receives the checksums
2013-07-29 11:30:21 -07:00
1c62adeda7
Handle extra-paremeter within checksum calculations
2013-07-29 11:30:17 -07:00
4a818a5e73
Refactor checksum
2013-07-29 11:30:17 -07:00
64a8dea9d7
Make sure the cookie is used in all registry queries
2013-07-25 12:31:23 -07:00
262838e069
Rename: VersionChecker->VersionInfo.
2013-07-23 17:05:13 -04:00
5f13f19407
documentation.
2013-07-18 14:22:49 -04:00
4b7dbfbcc3
reduce the number of string copy operations.
2013-07-10 18:59:43 -04:00
14155d6031
format in the user agent header should follow RFC 2616
2013-07-10 18:59:43 -04:00
e9e0d3c1c5
Removed an unnecessary nil assignment
2013-07-10 18:56:49 -04:00
6a2aee3043
Removed an unnecessary error check.
2013-07-10 18:56:49 -04:00
cf8afcf647
added client's kernel version
2013-07-10 18:56:49 -04:00
342460ed9a
inserted setUserAgent in each HTTP request
2013-07-10 18:49:01 -04:00
2e95c379d1
Added version checker interface
2013-07-10 18:49:01 -04:00
358574ab57
Hardened repos name validation
2013-07-09 16:46:55 -07:00
bf8d59a1d4
Fixed potential security issue (never try http on official index when polling the endpoint). Also fixed local repos name when pulling index.docker.io/foo/bar
2013-07-09 11:30:12 -07:00
67115ec479
fmt.Errorf instead of errors.New
2013-07-05 14:56:56 -07:00
98060903a9
Fixed ping URL
2013-07-05 14:55:48 -07:00
16fa043e34
Allowing namespaces in standalone registry
2013-07-05 14:30:43 -07:00
c6068feffa
Restoring old changeset lost by previous merge
2013-07-05 12:37:07 -07:00
6549d83e08
Merging from master
2013-07-05 12:27:10 -07:00
ec6d1d6020
Adding support for nicer URLs to support standalone registry (+ some registry code cleaning)
2013-07-05 12:20:58 -07:00
7df93a5ab3
Implement several golint suggestions, including:
...
* Removing type declarations where they're inferred
* Changing Url -> URL, Id -> ID in names
* Fixing snake-case names
2013-07-03 14:36:04 -07:00
7e215123fe
fix two obvious bugs???
2013-07-02 22:11:03 +00:00
258cbb06c9
Resolve conflict
2013-06-28 12:32:41 -07:00
03a77bd851
Fixed issue in registry.GetRemoteTags
2013-06-28 18:42:37 +02:00
259eeb382c
Remove https prefix from registry
2013-06-28 18:19:58 +02:00
e1d8d0245f
Rolled back of previous commit (skip cert verification)
2013-06-28 18:19:58 +02:00
dc97156c83
Skip certificate check (don't error out on self-signed certs)
2013-06-28 18:19:58 +02:00
7a664e6a5f
Tentative support for independent registries
2013-06-28 18:19:58 +02:00
0d85570c9b
URL schemes of both Registry and Index are now consistent
2013-06-27 17:55:17 -07:00
580d393d3c
Merge branch 'master' into simpler-build-upload
...
Conflicts:
api.go
builder_client.go
commands.go
2013-06-20 14:19:09 -07:00
f60888cc3b
rebase master
2013-06-20 13:56:36 +00:00
3238f3ea49
Use opaque requests when we need to preserve urlencoding in registry requests
2013-06-19 13:49:45 -07:00
7e78627908
hotfix: nil pointer uppon some registry error
2013-06-19 11:08:19 -07:00
c7e86e5eab
use go 1.1 cookiejar and revome ResetClient
2013-06-17 18:13:40 +00:00
508e152416
Merge branch 'master' into improve_progressbar_pull
2013-06-14 12:01:40 -07:00
95606a4363
Merge branch 'master' into postupload-endpoints-header
...
Conflicts:
server.go
2013-06-14 11:50:58 -07:00
ca71aa4f8d
Send X-Docker-Endpoints header when validating the images upload with the index at the end of a push
2013-06-10 11:21:56 -07:00
deddb3c757
Make the progressbar take the image size into consideration
2013-06-06 18:16:16 -07:00
55205e23b6
bump to master
2013-06-05 10:23:45 +00:00
e9ef3f43b7
Merge pull request #808 from dotcloud/795-lintify
...
Cleanup source
2013-06-04 14:20:38 -07:00
ead91d946e
linted names
2013-06-04 18:00:22 +00:00
93c7079f89
fix proxy
2013-06-04 15:44:27 +00:00
f9d88d8246
bump to master
2013-06-04 14:00:18 +00:00
f085aa4adc
drop/omit
2013-06-04 13:51:12 +00:00
b9e67a8884
Disabled HTTP keep-alive in the default HTTP client for Registry calls
2013-06-03 14:42:21 -07:00
6189c3cb0b
Minor changes in registry.go
2013-06-03 12:20:52 -07:00
fc340ec966
Fixed missing Body.Close when doing some HTTP requests. It should improve some request issues.
2013-06-03 12:14:57 -07:00
e6cc4ff646
move auth to the client WIP
2013-05-30 15:39:43 +00:00
e742b3efb6
Merge pull request #739 from dotcloud/push_issue-1
...
- Registry: Cereate a new registry object for each request (~session)
2013-05-29 09:22:12 -07:00
3e3a7c03ae
Documented who decides what and how.
2013-05-28 19:39:09 -07:00
2312a0e491
Cereate a new registry object for each request (~session)
2013-05-28 17:12:24 -07:00
6bd45ee686
fix docker login when same username
2013-05-24 14:23:43 +00:00
9373c8e459
Update Push to reflect the correct API
2013-05-16 14:33:29 -07:00
40ccd26d82
Remove hijack from api when not necessary
2013-05-16 12:09:06 -07:00
c8c892fec4
Disable registry unit tests
2013-05-15 17:57:53 -07:00
5e6d1a0d56
Update tests to reflect new AuthConfig
2013-05-15 17:31:11 -07:00
0933aa4424
Move authConfig from runtime to registry
2013-05-15 17:17:33 -07:00
4a0228fd8e
Allow to change login
2013-05-15 13:39:24 -07:00
a82a6bfdff
Upload images only when necessary
2013-05-15 13:22:57 -07:00
ffa1e56748
Move httpClient within registry object
2013-05-15 19:22:08 +00:00
b5d8930631
Remove stdout from registry
2013-05-15 18:50:52 +00:00
a2e94b289c
Refactor registry Push
2013-05-15 18:30:40 +00:00
1b23cb09da
Begin to implement push with new project structure
2013-05-15 03:27:15 +00:00
36b58e5abf
Split registry into subpackage
2013-05-15 01:41:39 +00:00
shin-
Andrews Medina
cressie176
Victor Vieux
Johan Euphrosine
Jonathan Rudenberg
Ken Cochrane
Michael Crosby
Guillaume J. Charmes
Marco Hennings
Guillaume J. Charmes
Victor Vieux
Sam Alba
Nan Monnand Deng
Guillaume J. Charmes
Caleb Spare
Tobias Schwab
Solomon Hykes