Use correct regexp in reference.WithTag
This was using a different regexp from the intended one. This meant that tags with uppercase characters were not accepted. Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>master
							parent
							
								
									987a69dd05
								
							
						
					
					
						commit
						985ee759e7
					
				|  | @ -213,7 +213,7 @@ func WithName(name string) (Named, error) { | |||
| // WithTag combines the name from "name" and the tag from "tag" to form a
 | ||||
| // reference incorporating both the name and the tag.
 | ||||
| func WithTag(name Named, tag string) (NamedTagged, error) { | ||||
| 	if !anchoredNameRegexp.MatchString(tag) { | ||||
| 	if !anchoredTagRegexp.MatchString(tag) { | ||||
| 		return nil, ErrTagInvalidFormat | ||||
| 	} | ||||
| 	return taggedReference{ | ||||
|  |  | |||
|  | @ -417,6 +417,11 @@ func TestWithTag(t *testing.T) { | |||
| 			tag:      "tag4", | ||||
| 			combined: "test.com:8000/foo:tag4", | ||||
| 		}, | ||||
| 		{ | ||||
| 			name:     "test.com:8000/foo", | ||||
| 			tag:      "TAG5", | ||||
| 			combined: "test.com:8000/foo:TAG5", | ||||
| 		}, | ||||
| 	} | ||||
| 	for _, testcase := range testcases { | ||||
| 		failf := func(format string, v ...interface{}) { | ||||
|  |  | |||
		Loading…
	
		Reference in New Issue