daniel
/
distribution
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

improve trusted location detection 

Docker-DCO-1.1-Signed-off-by: Victor Vieux <vieux@docker.com> (github: vieux)
master
Victor Vieux 2014-06-07 21:17:56 +00:00
parent df9d5752ec
commit 5cef006c5a
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/registry.go
View File

@ -766,7 +766,7 @@ func trustedLocation(req *http.Request) bool {
}
for _, trusted := range trusteds {
if strings.HasSuffix(hostname, trusted) {
if hostname == trusted || strings.HasSuffix(hostname, "."+trusted) {
return true
}
}

2
docs/registry_test.go
View File

@ -235,7 +235,7 @@ func TestValidRepositoryName(t *testing.T) {
}
func TestTrustedLocation(t *testing.T) {
for _, url := range []string{"http://example.com", "https://example.com:7777", "http://docker.io", "http://test.docker.io"} {
for _, url := range []string{"http://example.com", "https://example.com:7777", "http://docker.io", "http://test.docker.io", "https://fakedocker.com"} {
req, _ := http.NewRequest("GET", url, nil)
if trustedLocation(req) == true {
t.Fatalf("'%s' shouldn't be detected as a trusted location", url)