Create client transport package

Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)

registry/client/repository.go

@@ -18,16 +18,17 @@ import (
 	"github.com/docker/distribution"
 	"github.com/docker/distribution/context"
 	"github.com/docker/distribution/registry/api/v2"
+	"github.com/docker/distribution/registry/client/transport"
 	"github.com/docker/distribution/registry/storage/cache"
 )
 
-// NewRepository creates a new Repository for the given repository name and endpoint
-func NewRepository(ctx context.Context, name, endpoint string, transport http.RoundTripper) (distribution.Repository, error) {
+// NewRepository creates a new Repository for the given repository name and base URL
+func NewRepository(ctx context.Context, name, baseURL string, transport http.RoundTripper) (distribution.Repository, error) {
 	if err := v2.ValidateRespositoryName(name); err != nil {
 		return nil, err
 	}
 
-	ub, err := v2.NewURLBuilderFromString(endpoint)
+	ub, err := v2.NewURLBuilderFromString(baseURL)
 	if err != nil {
 		return nil, err
 	}
@@ -292,7 +293,7 @@ func (ls *blobs) Open(ctx context.Context, dgst digest.Digest) (distribution.Rea
 		return nil, err
 	}
 
-	return NewHTTPReadSeeker(ls.repository.client, blobURL, stat.Length), nil
+	return transport.NewHTTPReadSeeker(ls.repository.client, blobURL, stat.Length), nil
 }
 
 func (ls *blobs) ServeBlob(ctx context.Context, w http.ResponseWriter, r *http.Request, dgst digest.Digest) error {

registry/client/transport/authchallenge.go

@@ -1,4 +1,4 @@
-package client
+package transport
 
 import (
 	"net/http"

registry/client/transport/authchallenge_test.go

@@ -1,4 +1,4 @@
-package client
+package transport
 
 import (
 	"net/http"

registry/client/transport/http_reader.go

@@ -1,4 +1,4 @@
-package client
+package transport
 
 import (
 	"bufio"

registry/client/transport/session.go

@@ -1,4 +1,4 @@
-package client
+package transport
 
 import (
 	"encoding/json"

registry/client/transport/session_test.go

@@ -1,4 +1,4 @@
-package client
+package transport
 
 import (
 	"encoding/base64"
@@ -11,6 +11,12 @@ import (
 	"github.com/docker/distribution/testutil"
 )
 
+func testServer(rrm testutil.RequestResponseMap) (string, func()) {
+	h := testutil.NewHandler(rrm)
+	s := httptest.NewServer(h)
+	return s.URL, s.Close
+}
+
 type testAuthenticationWrapper struct {
 	headers   http.Header
 	authCheck func(string) bool

registry/client/transport/transport.go

@@ -1,4 +1,4 @@
-package client
+package transport
 
 import (
 	"io"